Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix head_mask for albert encoder part(AlbertTransformer) #11596

Merged
merged 2 commits into from May 6, 2021

Conversation

@baeseongsu
Copy link
Contributor

@baeseongsu baeseongsu commented May 5, 2021

What does this PR do?

Fixes #8323

Fix a subtle bug for using a submodule AlbertTransformer in AlbertModel.

Who can review?

@LysandreJik

@LysandreJik
Copy link
Member

@LysandreJik LysandreJik commented May 5, 2021

Great, thanks for the fix @baeseongsu ! Could you run the code quality tool to ensure the PR fits the quality requirements?

pip install -U -e .[quality]
make fixup
@baeseongsu
Copy link
Contributor Author

@baeseongsu baeseongsu commented May 5, 2021

@LysandreJik Sure 👍

Copy link
Member

@LysandreJik LysandreJik left a comment

LGTM, thanks a lot @baeseongsu!

@LysandreJik LysandreJik merged commit c1780ce into huggingface:master May 6, 2021
14 checks passed
14 checks passed
@github-actions
run_tests_templates
Details
ci/circleci: build_doc Your tests passed on CircleCI!
Details
ci/circleci: check_code_quality Your tests passed on CircleCI!
Details
ci/circleci: check_repository_consistency Your tests passed on CircleCI!
Details
ci/circleci: run_examples_torch Your tests passed on CircleCI!
Details
ci/circleci: run_tests_custom_tokenizers Your tests passed on CircleCI!
Details
ci/circleci: run_tests_flax Your tests passed on CircleCI!
Details
ci/circleci: run_tests_hub Your tests passed on CircleCI!
Details
ci/circleci: run_tests_pipelines_tf Your tests passed on CircleCI!
Details
ci/circleci: run_tests_pipelines_torch Your tests passed on CircleCI!
Details
ci/circleci: run_tests_tf Your tests passed on CircleCI!
Details
ci/circleci: run_tests_torch Your tests passed on CircleCI!
Details
ci/circleci: run_tests_torch_and_flax Your tests passed on CircleCI!
Details
ci/circleci: run_tests_torch_and_tf Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants